Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codegen record lens #1249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix codegen record lens #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c87df
adds test with compilation error (codegen) when `using LanguageExt" i…
StefanBertels Sep 12, 2023
fec2445
fix CodeGen (record => lens part => full qualified typename)
StefanBertels Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions LanguageExt.CodeGen/CodeGenUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public static TypeDeclarationSyntax AddLenses(TypeDeclarationSyntax partialClass
public static TypeDeclarationSyntax AddLensProp(TypeDeclarationSyntax partialClass, TypeSyntax returnType, (SyntaxToken Identifier, TypeSyntax Type, SyntaxTokenList Modifiers, SyntaxList<AttributeListSyntax> Attrs) member) =>
partialClass.AddMembers(
PropertyDeclaration(
GenericName(Identifier("Lens"))
GenericName(Identifier("LanguageExt.Lens"))
.WithTypeArgumentList(TypeArgumentList(SeparatedList<TypeSyntax>(new[] { returnType, member.Type }))),
Identifier(MakeCamelCaseId(member.Identifier).Text))
.WithModifiers(
Expand All @@ -220,7 +220,7 @@ public static TypeDeclarationSyntax AddLens(TypeDeclarationSyntax partialClass,
{
var lfield = FieldDeclaration(
VariableDeclaration(
GenericName(Identifier("Lens"))
GenericName(Identifier("LanguageExt.Lens"))
.WithTypeArgumentList(
TypeArgumentList(SeparatedList<TypeSyntax>(new[] { returnType, member.Type }))))
.WithVariables(
Expand All @@ -231,7 +231,7 @@ public static TypeDeclarationSyntax AddLens(TypeDeclarationSyntax partialClass,
InvocationExpression(
MemberAccessExpression(
SyntaxKind.SimpleMemberAccessExpression,
GenericName("Lens")
GenericName("LanguageExt.Lens")
.WithTypeArgumentList(
TypeArgumentList(
SeparatedList<TypeSyntax>(new[] { returnType, member.Type }))),
Expand Down
9 changes: 9 additions & 0 deletions LanguageExt.Tests/RecordCodeGenWithoutUsingLanguageExt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
namespace LanguageExt.Tests;

[Record]
public partial class RecordCodeGenWithoutUsingLanguageExt
{
public int SomeProperty { get; }

public static RecordCodeGenWithoutUsingLanguageExt AnotherNew() => New(0b101010);
}