-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize HTML before comparison #26
Conversation
that seems nice (solving #18) not sure but could we avoid normalizing if possible? I'm thinking of something better: maybe when render() is called we should store some |
Not sure but I also think calling innerHtml has a cost |
@slorber The whole idea of this component is that |
Looks like an equally valid workaround to me. I however do not see anymore why we need such a workaround at all. Maybe I am too sleepy, but the 'something better' solution slorber suggested sounds sound to me now. The reason is that browser reformatting should not be a problem at all. Assume we render some html, and the browser reformats it. There are then two ways the
So just adding a check whether the html is any different from last time should be enough. We do not even need to store it in |
Hi all! I don't use this project myself anymore, and don't really have time for it at the moment. You may all be more knowledgeable about this module than I am. Do some of you have the time and goodwill to help me maintain this repo on github? |
same for me unfortunatly I can only provide feedback from my own experience |
Heh, our project ended up taking pieces of this code and adapting it. We had some unfortunate interactions that didn't fit this model. |
any example? maybe you are not alone (I don't use react-contenteditable either) |
So, is this PR outdated by #27 ? Can I close it ? |
If I am not mistaken this should indeed be outdated by #27. Regarding maintainance, I could try help out at least while using the module in my own project. |
An alternative fix to @Treora's PR.