Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to create hooks folder #45

Merged
merged 3 commits into from
Apr 18, 2019
Merged

try to create hooks folder #45

merged 3 commits into from
Apr 18, 2019

Conversation

lovato
Copy link
Owner

@lovato lovato commented Apr 18, 2019

No description provided.

@lovato lovato self-assigned this Apr 18, 2019
@lovato
Copy link
Owner Author

lovato commented Apr 18, 2019

Fixes #43

@coveralls
Copy link

coveralls commented Apr 18, 2019

Pull Request Test Coverage Report for Build 169

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 162: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@lovato lovato merged commit 5d79cae into develop Apr 18, 2019
@lovato lovato deleted the fix/create_hooks_folder branch April 18, 2019 19:37
@@ -102,7 +102,15 @@ def add_hooks(path=os.environ["PWD"]):
if git_path:
path = os.path.abspath(path)
setup_path = os.path.abspath(setup_path)
if os.path.isdir(os.path.join(git_path, "hooks")):
hooks_path = os.path.join(git_path, "hooks")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract this to a method, e.g. ensure_hooks_dir_exists, so you can easily test it by giving it a fake directory

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see it, sorry. I was following up on the issue. I will work on this.

@lovato lovato restored the fix/create_hooks_folder branch April 22, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants