Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various functions, enums, and type modification. #89

Merged
merged 31 commits into from
Sep 28, 2020

Conversation

MikuAuahDark
Copy link
Member

@MikuAuahDark MikuAuahDark commented Jul 29, 2020

This is somewhat a big changes. These changes were made when I was making Teal type definitions for LOVE, but I think it's useful to have some of the changes to upstream. Feel free to review and add comment, but I'll keep it in draft state until I completed it.

Progress:

  • Add dpiscale parameter to love.graphics.newFont 2nd and 3rd variants.
  • Move Drawable from love to love.graphics.
  • Move ByteData from love to love.data.
  • Add DisplayOrientation enum to love.window.
  • Add DroppedFile type to love.filesystem.
  • Add Object methods.
  • Add VertexAttributeStep enum to love.graphics.
  • Load VertexWinding enum in love.graphics.
  • Add IndexDataType enum to love.graphics.
  • Add PixelFormat enum to love.image (partial, some descriptions needs attention).
  • Add 2nd variant of love.graphics.newShader.
  • Add love.font module.
    • GlyphData type and methods.
    • Rasterizer type and methods.
    • HintingMode enum.
    • love.font functions.
  • Rename Transform:isAffine to Transform:isAffine2DTransform.
  • Move CompressedDataFormat from love.math to love.data.
  • Move CompressedData from love.math to love.data.
  • Add more constants to CompareMode enum.
  • Remove "already-removed" constants from GraphicsFeature enum.
  • Remove "canvasfsaa" constant from GraphicsLimit enum.
  • Add more Texture functions.
  • Remove duplication of various function in Image and Canvas which is available in Texture.
  • Rename CanvasMipmapMode to MipmapMode.

@MikuAuahDark MikuAuahDark marked this pull request as ready for review July 31, 2020 10:10
@MikuAuahDark
Copy link
Member Author

There are some problems

  1. Some description for PixelFormat enum needs better description.
  2. The HTML generator doesn't see love.font module for some reason.

@hahawoo hahawoo merged commit 240628b into love2d-community:master Sep 28, 2020
@hahawoo
Copy link
Contributor

hahawoo commented Sep 28, 2020

Thank you! :) I left love.font out of the HTML generator because, as far as I knew at the time, these functions were used internally in LOVE's code but there wasn't a reason for a LOVE user to use them instead of love.graphics.newFont or love.graphics.newImageFont, but please let me know if I was mistaken!

@MikuAuahDark
Copy link
Member Author

Looks like http://love2d-community.github.io/love-api/ is not updated yet after this merge.

MikuAuahDark added a commit to MikuAuahDark/love2d-tl that referenced this pull request Oct 1, 2020
Since love2d-community/love-api#89 has been merged, then it's unnecessary to use my own fork anymore unless there are more changes.
@hahawoo
Copy link
Contributor

hahawoo commented Dec 4, 2020

Sorry @MikuAuahDark, I somehow didn't see your comment unti now. This project doesn't really seem to have an active maintainer, and I don't want to actively maintain it. Would you like to, or know anyone who would? :) I think updating the HTML page is simply a matter of running html-generator.lua and uploading the resulting page. And/or, would you like to maintain loveref.github.io? It is basically the same but with a URL and a design that I prefer.

@MikuAuahDark
Copy link
Member Author

Actually I have write access to this repo, but since I don't want to suddenly push lots of change without any discussion first, I made it as PR instead.

About loveref.github.io, I personally prefer the love2d-community.github.io/love-api style, although I think some text are simply too small, but that can be fixed by increasing the size of the text. I think automating the updates with GitHub Actions is possible, but I can't promise anything for the next 2 weeks.

@hahawoo
Copy link
Contributor

hahawoo commented Dec 6, 2020

Awesome, well if you find a way to automate the updates I'll do the same thing with loveref.github.io :)

Regarding making the text bigger, you might want to check out and merge PR #80

@MikuAuahDark
Copy link
Member Author

After checking the repo, why doesn't this used? https://github.com/love2d-community/love-api/blob/master/.travis/push.sh

Anyway we may able to discuss about automating further in Discord.

@hahawoo
Copy link
Contributor

hahawoo commented Dec 18, 2020

I'm not sure, I believe @rm-code and @daviel set this up.

While I can't say that I'm the "owner" of this repo (@rm-code again did the work for this, which I'm grateful for), you have my blessing (for what it's worth) @MikuAuahDark to automate and otherwise improve this project in any way you see fit (as does anyone else with write access to this repo).

@MikuAuahDark
Copy link
Member Author

Well, I guess I'll wait for their replies first then. I don't want to mess up anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants