Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using enet causes Cannot push enet peer to Lua: pointer value %p is too large #222

Closed
kungfoo opened this issue Dec 9, 2021 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@kungfoo
Copy link

kungfoo commented Dec 9, 2021

I tried updating my app to the newest main branch state and it is using enet for communication with the server.

When I try to connect the enet host, the app throws this exception. This is with a debug build on a Pixel 4 (updated to Android 12).

Not sure if I'm building it wrong, or if there is something wrong.

@MikuAuahDark
Copy link
Collaborator

MikuAuahDark commented Dec 9, 2021

Looks like the fix is trivial. love2d/love@4f491c2 (#200) just needs to be applied to ENet too.

@MikuAuahDark MikuAuahDark added the bug Something isn't working label Dec 9, 2021
@MikuAuahDark MikuAuahDark added this to the 11.4 milestone Dec 9, 2021
@slime73
Copy link
Member

slime73 commented Dec 9, 2021

Just to confirm, your local code has the change AuahDark linked?

@kungfoo
Copy link
Author

kungfoo commented Dec 9, 2021

I deleted the invalid comment: nogame.lua works fine, using enet is what crashes it.

@kungfoo
Copy link
Author

kungfoo commented Dec 9, 2021

I ported a really ugly hacky version of the fix and can report that it works. I can try preparing a PR for upstream, if desired.

@MikuAuahDark
Copy link
Collaborator

Sure. I was bit puzzled since I don't know the obvious location where actually those keys are used.

@slime73
Copy link
Member

slime73 commented Dec 13, 2021

I think it's just compute_peer_key / push_peer (in enet.cpp) that need to change, similar to the main LÖVE commit. I'll see about implementing it shortly.

@kungfoo
Copy link
Author

kungfoo commented Dec 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants