Recording support for Android (Java side) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support of recording capabilities to Android, which includes requesting the permission and prompt it to user.
The changes (including C++ side PR)
t.audio.micconfiguration inconf.luaand store it somewhere.love.audiois loaded, it reads the value oft.audio.micpreviously set.t.audio.micis true, it requests mic permission. The result is used later.love.audio.getRecordingDevicesis called:4a. If user denies the permission (incl. ticking "Don't Ask Again"), dialog will be shown to prompt user and this function will return empty list of recording devices.
4b. If user granted the permission, this function will enumerate recording devices as usual.
C++ side PR: https://bitbucket.org/rude/love/pull-requests/126