Show deprecation notice when slashes is passed to require. #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't forgotten about this, I just need to think about it a bit but haven't had the time lately |
|
No worries. Take your time. |
|
Let's try it out and see how it goes. However we'll probably need to keep code around forever to do the slash replacement, to make sure it errors (or shows the deprecation notice) rather than not finding the file and therefore falling back to Lua's built in searcher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1773, it's probably a good idea to show a warning about usage of slashes in
require, then evalue when to enforce this by throwing Lua error.