Replace Mpg123 with dr_mp3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: macOS/iOS xcodeproj
MikuAuahDark
commented
Feb 16, 2020
This was referenced Feb 20, 2020
MikuAuahDark
added a commit
to love2d/love-android
that referenced
this pull request
Mar 4, 2020
MikuAuahDark
added a commit
to love2d/megasource
that referenced
this pull request
Oct 15, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1504
Note that this pull request is incomplete:
I haven't fully tested if this really works (need to sleep as of writing). I'll update this once I'm able to test it in Windows and Linux.I've tested this in Windows but the file loading performance is 4x slower than Mpg123. Not sure if this is worth it. It's a tradeoff between maintaining Mpg123 library vs. single-source MP3 decoder.