Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator precedence; #18

Merged
merged 1 commit into from
May 28, 2023
Merged

Fix operator precedence; #18

merged 1 commit into from
May 28, 2023

Conversation

bjornbytes
Copy link
Contributor

Bitwise AND has lower precedence than equality.

Bitwise AND has lower precedence than equality.
@MikuAuahDark MikuAuahDark merged commit fd569fa into love2d:main May 28, 2023
6 checks passed
@slime73
Copy link
Member

slime73 commented May 28, 2023

This actually breaks things for me, e.g. this code hits the assert now when using the schannel backend:

local code, body = https.request("https://example.com")
assert(code == 200, body)

So there might be a lot more to unravel with the changed code in order to properly address it. However since the new WinINet backend is used by default now instead of the SChannel backend, maybe it doesn't matter.

@slime73
Copy link
Member

slime73 commented May 28, 2023

I think I'll revert the change for now since I'd rather all backends to work than not, and we can decide what to do from there.

@bjornbytes
Copy link
Contributor Author

Oops, I was testing on the wrong backend. Looks like the SChannel backend always looks at the flags regardless of whether QueryContextAttributes was successful, but because it gets the operator precedence wrong it ends up accidentally doing nothing. At this point I guess I'll just back away slowly and disable that backend.

@MikuAuahDark
Copy link
Contributor

With recent commits, WinINet is used instead of Schannel unless user sets certain environment variables to disable WinINet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants