Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I need to make slug 特殊天-1 --> te-shu-tian-1 #28

Closed
deligence-dharmendra opened this issue Dec 29, 2017 · 3 comments
Closed

I need to make slug 特殊天-1 --> te-shu-tian-1 #28

deligence-dharmendra opened this issue Dec 29, 2017 · 3 comments
Labels
bug
Milestone
v1.6.0

Comments

@deligence-dharmendra
Copy link

Hi,
I using this library for making slug in our app. But I'm getting the issue when I try making a slug of
"特殊天-1"
my expected result is te-shu-tian-1
but the actual output is te-shu-tian1

Please advice
Merged
16 tasks
lovell added a commit that referenced this issue Jan 1, 2018
@lovell
Only merge digit suffixes when using tone numbers #28
02f7748
@lovell lovell added the bug label Jan 1, 2018
@lovell
Copy link
Owner

lovell commented Jan 1, 2018

Hello, thanks for reporting this. It looks like a bug when Pinyin transliteration is used without tone numbers. The fix and your example as a unit test are added in commit 02f7748.

@lovell lovell added this to the v1.6.0 milestone Jan 1, 2018
@lovell
Copy link
Owner

lovell commented Jan 1, 2018

v1.6.0 now available.

@lovell lovell closed this as completed Jan 1, 2018
@deligence-dharmendra
Copy link
Author

Hello, Thanks after the upgrade the version it's working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@lovell @deligence-dharmendra