Github functionality broken -- please read. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no longer supported. Please use GET.' Resolves issue with private files from github failing to download.
jukart
added a commit
that referenced
this pull request
Mar 19, 2012
Github functionality broken -- please read.
|
Thanks for the fix. I was looking after this this morning :) |
|
The pleasure is mine. Thank you for the quick turnaround on the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private repository pulls from GitHub broke on me on Friday (or it might have been Thursday); I spent hours trying to figure out what went wrong.
I finally figured out that POST request for authentication to github private repositories is no longer supported at all; you get a helpful 422 error code if you try.
This change alters authentication to use GET instead of POST and I can confirm it works again. All unit tests passing for me.