This repository has been archived by the owner on May 2, 2022. It is now read-only.
closing and required parameters #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As the GCP project id is required, it is less confusing to have it as a required parameter in order to benefit from compile time checks.
heltonmarx
reviewed
Jul 14, 2017
| "github.com/golang/protobuf/ptypes/timestamp" | ||
| gax "github.com/googleapis/gax-go" |
There was a problem hiding this comment.
One concern about gax is : This project is currently experimental and not supported
There was a problem hiding this comment.
It's a dependency of the protobuf client we are using, not sure we can do much there. We are using the protobuf client directly here rather than the official StackDriver client.
heltonmarx
reviewed
Jul 14, 2017
README.md
Outdated
| if err != nil { | ||
| log.Fatalf("error creating a recorder: %v", err) | ||
| } | ||
|
|
* Adds a close method for the recorder. Calling close flushes the buffered traces and closes the underlying client. * Inverts the dependency of the tracing client. Allows for easier testing and alternative implementations.
heltonmarx
approved these changes
Jul 14, 2017
tecbot
approved these changes
Jul 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I propose the following changes:
Add a
Close()method for the Recorder. This will allow users to flush the buffers before their application terminates and thus avoid dropping traces.Make
Project IDa required parameter. Recorder throws an error at the moment if WithProjectID("--") is not given which is a bit confusing. Making it a required parameter makes the need for this parameter explicit.Invert the dependency to Google's protobuf client. This allows for easier testing or alternative implementations. Building the client should not probably be the recorder's responsibility.