Tester tolerate unconsumed queues #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frairon
force-pushed
the
tester-tolerate-unconsumed-queues
branch
4 times, most recently
from
1979be0
to
63f6d26
Compare
frairon
force-pushed
the
tester-tolerate-unconsumed-queues
branch
from
63f6d26
to
4bd0eff
Compare
kavinsk1
approved these changes
Aug 14, 2019
| log.Printf("wait 5 seconds before starting to emit") | ||
| time.Sleep(5 * time.Second) | ||
|
|
||
| for i := 0; i < 50; i++ { |
There was a problem hiding this comment.
These loops could use some more overview imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased this branch onto the master. Hopefully I did not do any mistakes there @frairon.
Tests still work fine.
I want this in the master because we have version conflicts between projects otherwise.