Panic documentation & Migration guide #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattburman
reviewed
Apr 27, 2020
MIGRATION.md
Outdated
|
|
||
| // After migration: | ||
| // create a view | ||
| view09x, _ := NewView(..., WithAutoReconnect()) |
There was a problem hiding this comment.
should this be WithViewAutoReconnect?
There was a problem hiding this comment.
good catch Matt. Should've tried to compile the snippet I guess.
mattburman
reviewed
Apr 27, 2020
MIGRATION.md
Outdated
| ```go | ||
|
|
||
| // create a view | ||
| view014, _ := NewView(..., WithRestartable()) |
There was a problem hiding this comment.
Similarly this is WithViewRestartable. Though maybe it's good to be "incorrect" since it's the old version and shouldn't be copied since it's just an example
mattburman
reviewed
Apr 27, 2020
| @@ -0,0 +1,41 @@ | |||
| This document sums up issues for migrating between 0.1.4 to 0.9.x | |||
There was a problem hiding this comment.
The guide is really clear, nice work 👍
There was a problem hiding this comment.
If there something else that needs to be documented let me know. It's just a start...
frairon
force-pushed
the
249-migration-guide
branch
from
d7fb26e
to
1b7c0e2
Compare
R053NR07
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.