Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tests #309

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fixed tests #309

merged 1 commit into from
Mar 15, 2021

Conversation

frairon
Copy link
Contributor

@frairon frairon commented Mar 14, 2021

No description provided.

@mmreza79
Copy link
Contributor

mmreza79 commented Mar 15, 2021

One question. Is there any difference between Emit and EmitWithHeaders in this PR because you didn't pass any header info.

@frairon
Copy link
Contributor Author

frairon commented Mar 15, 2021

For this test there is no difference, but the underlying context-implementation changed. A producer has the methods Emit and EmitWithHeaders, those are used when e.g. you call ctx.Emit(..), because the producer-method is passed to the callback-context here: https://github.com/lovoo/goka/blob/master/partition_processor.go#L497
So whatever is passed there, will be called (whether headers are used or not).
And since this commit, EmitWithHeaders is always used, so the mock has to expect that too or the tests will fail.

@frairon frairon merged commit 3902905 into master Mar 15, 2021
@frairon frairon deleted the fix-tests branch March 15, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants