Remove Prefix from logging, moved logging package to goka #305 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frairon
force-pushed
the
305/logging-interface
branch
from
05d0f2e
to
4db0008
Compare
frairon
force-pushed
the
305/logging-interface
branch
from
4db0008
to
e3fc0c4
Compare
Closed
jomaresch
previously approved these changes
Apr 8, 2021
frairon
force-pushed
the
305/logging-interface
branch
from
e3fc0c4
to
29aeb8e
Compare
jomaresch
approved these changes
May 19, 2021
|
@frairon Awesome are you going to create a new version for this? (v1.0.7 ??) |
|
Yes, absolutely. But since this is a breaking change (even though it's small), I wanted to wait until the other changes are merged, so we can do a minor release including all that. Shouldn't take that long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.