Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage improvements #328

Merged
merged 1 commit into from
May 28, 2021
Merged

storage improvements #328

merged 1 commit into from
May 28, 2021

Conversation

frairon
Copy link
Contributor

@frairon frairon commented May 28, 2021

Some minor improvements to goka's default leveldb-implementation.

  • no transaction during recovery
  • regular offset commit during recovery

This solves:

  • big memory spike when recovering huge tables
  • long wait after recovery to commit the transaction
  • long wait when re-opening leveldb after unclean shutdown

@frairon frairon merged commit 96c71bc into master May 28, 2021
@frairon frairon deleted the leveldb-storage-improvements branch May 28, 2021 09:57
@andronux
Copy link

Hello!

this fix hasn't been released yet right?

We're experiencing a high spike in memory consumption when recovering huge tables (starting the app).

Thanks

@frairon
Copy link
Contributor Author

frairon commented Sep 15, 2021

Hey @andronux,
oh damn you're right. We were postponing the release since we've had some breaking changes and wanted to fix some bugs. to get you started though, we just pre-released the current master to v1.1.0-beta.0. There's still at least one issue for failing processors like #334, but that's quite an edge case.

@andronux
Copy link

Hey @frairon !

thank you for your quick response!

We'll go ahead and give this release a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants