partition table: always store offset #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the functionality of "store only newest offest" in the partition table during
SetValue()
.The idea of this limitation was to make sure we don't overwrite new partition-offsets with old values. However, a side effect was that if the offset was somehow corruped and higher than the actual offset, it would never get fixed.
The function was actually never necessary, because
SetValues()
are executed sequentially per partitionThis should also reduce some load from the storage, since it removes the extra
GetOffset
on everySetValue
.