fixed comments from PR #341, added unit tests for action #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frairon
force-pushed
the
visitor-tool-comments
branch
from
6fc95de
to
e1feb55
Compare
frairon
force-pushed
the
visitor-tool-comments
branch
from
e1feb55
to
ee738ce
Compare
ubunatic
reviewed
Sep 13, 2021
| // | ||
| // Note: The committed offset should always be the offset of the next message that your application will read. Thus, when calling commitSync(offsets) you should add one to the offset of the last message processed. | ||
| // | ||
| // This has the same semantics as sarama's implementation of session.MarkMessage (which calls MarkOffset with offset+1) |
There was a problem hiding this comment.
Thanks for the details, I think they are critical to document here. 👍
Co-authored-by: Uwe Jugel <uwe.jugel@lovoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.