improving processor error handling/shutdown #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace multierr.Errors with hashicorp/go-multierror
frairon
changed the title
ubunatic
reviewed
Sep 30, 2021
jomaresch
reviewed
Sep 30, 2021
ubunatic
approved these changes
Oct 1, 2021
| @@ -314,7 +284,7 @@ func (g *Processor) Run(ctx context.Context) (rerr error) { | |||
| g.log.Debugf("closing producer") | |||
| defer g.log.Debugf("producer ... closed") | |||
| if err := g.producer.Close(); err != nil { | |||
| merrors.Collect(fmt.Errorf("error closing producer: %v", err)) | |||
| errs = multierror.Append(errs, fmt.Errorf("error closing producer: %w", err)) | |||
There was a problem hiding this comment.
Setting the errs here in this deferred func and then later using the errs to fill the rerr in the previous (but later called) deferred func still twists my head. This whole reversed defer processing makes this really hard to understand.
I think the code is correct, but if there is a cleaner way to write this, the code would be more maintainable.
There was a problem hiding this comment.
I also don't like to modify the the return value in a deferred function, but haven't found a better solution yet. Maybe we'll find another way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two main things: