Expose Processor State With StateReader Interface #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `PartitionTable.WaitRecovered()` now returns a read only channel.
jomaresch
commented
Oct 3, 2021
frairon
reviewed
Oct 3, 2021
| // StateReader is a read only abstraction of a Signal to expose the current state. | ||
| type StateReader interface { | ||
| State() State | ||
| WaitForState(state State) <-chan struct{} |
There was a problem hiding this comment.
What about the other functions? I know they're mostly duplication, but it's convenient :). And if we have them anyway, why not expose them in the reader interface?
I mean IsState and WaitForStateMin and ObserveStateChange
There was a problem hiding this comment.
Good idea + maybe we can change the places where we read/wait/watch state (if any) to use the reader and not access the state directly (in another PR, if you think this makes sense)
frairon
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343
StateReaderto the processor to expose the current state.PartitionTable.WaitRecovered()now returns a read only channel.