Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default channel size from sarama in kafka package #73

Merged
merged 1 commit into from
Jan 4, 2018
Merged

use default channel size from sarama in kafka package #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion kafka/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ func CreateDefaultSaramaConfig(clientID string, partitioner sarama.PartitionerCo

config.Version = sarama.V0_10_1_0
config.ClientID = clientID
config.ChannelBufferSize = defaultChannelBufferSize

// consumer configuration
config.Consumer.Return.Errors = true
Expand Down
8 changes: 6 additions & 2 deletions kafka/consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

const (
// size of sarama buffer for consumer and producer
defaultChannelBufferSize = 10
defaultChannelBufferSize = 256

// time sarama-cluster assumes the processing of an event may take
defaultMaxProcessingTime = 1 * time.Second
Expand Down Expand Up @@ -52,7 +52,11 @@ type saramaConsumer struct {

// NewSaramaConsumer creates a new Consumer using sarama
func NewSaramaConsumer(brokers []string, group string, config *cluster.Config) (Consumer, error) {
events := make(chan Event, defaultChannelBufferSize)
chsize := config.Config.ChannelBufferSize
if chsize == 0 {
chsize = defaultChannelBufferSize
}
events := make(chan Event, chsize)

g, err := newGroupConsumer(brokers, group, events, config)
if err != nil {
Expand Down