prevent panic if no decode function is registered

lovromazgon · May 27, 2024 · 8611343 · 8611343
1 parent 556abe3
commit 8611343
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pkg/sr/serde.go b/pkg/sr/serde.go
@@ -387,7 +387,7 @@ func (s *Serde) decodeFind(b []byte) ([]byte, tserde, error) {
 			t = t.subindex[idx]
 		}
 	}
-	if !t.exists {
+	if !t.exists || t.decode == nil {
 		return nil, tserde{}, ErrNotRegistered
 	}
 	return b, t, nil

diff --git a/pkg/sr/serde_test.go b/pkg/sr/serde_test.go
@@ -53,6 +53,7 @@ func TestSerde(t *testing.T) {
 	serde.Register(3, idx4{}, Index(0, 0, 1))
 	serde.Register(3, idx3{}, Index(0, 0))
 	serde.Register(5, oneidx{}, Index(0), GenerateFn(func() any { return &oneidx{Foo: "defoo", Bar: "debar"} }))
+	serde.Register(101, struct{}{}, DecodeFn(nil))
 
 	for i, test := range []struct {
 		enc    any
@@ -154,8 +155,8 @@ func TestSerde(t *testing.T) {
 	if _, err := serde.DecodeNew([]byte{0, 0, 0, 0, 99}); err != ErrNotRegistered {
 		t.Errorf("got %v != exp ErrNotRegistered", err)
 	}
-	if _, err := serde.DecodeNew([]byte{0, 0, 0, 0, 100, 0}); err != ErrNotRegistered {
-		// schema is registered but type is unknown
+	if _, err := serde.DecodeNew([]byte{0, 0, 0, 0, 101, 0}); err != ErrNotRegistered {
+		// schema is registered but no decode function
 		t.Errorf("got %v != exp ErrNotRegistered", err)
 	}
 }