Skip to content

Commit

Permalink
fix(build): Reduce spaces in build output.
Browse files Browse the repository at this point in the history
  • Loading branch information
StephanieJKS committed Oct 16, 2023
1 parent cdd9bdc commit 2e14c4f
Show file tree
Hide file tree
Showing 19 changed files with 28 additions and 179 deletions.
5 changes: 1 addition & 4 deletions packages/build/src/build/writeApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@
import { serializer } from '@lowdefy/helpers';

async function writeApp({ components, context }) {
await context.writeBuildArtifact(
'app.json',
serializer.serializeToString(components.app ?? {}, { space: 2 })
);
await context.writeBuildArtifact('app.json', serializer.serializeToString(components.app ?? {}));
}

export default writeApp;
9 changes: 1 addition & 8 deletions packages/build/src/build/writeApp.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ test('writeApp', async () => {
},
};
await writeApp({ components, context });
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'app.json',
`{
"key": "value"
}`,
],
]);
expect(mockWriteBuildArtifact.mock.calls).toEqual([['app.json', `{"key":"value"}`]]);
});

test('writeApp empty config', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/build/writeAuth.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { serializer } from '@lowdefy/helpers';
async function writeAuth({ components, context }) {
await context.writeBuildArtifact(
'auth.json',
serializer.serializeToString(components.auth ?? {}, { space: 2 })
serializer.serializeToString(components.auth ?? {})
);
}

Expand Down
9 changes: 1 addition & 8 deletions packages/build/src/build/writeAuth.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ test('writeAuth', async () => {
},
};
await writeAuth({ components, context });
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'auth.json',
`{
"key": "value"
}`,
],
]);
expect(mockWriteBuildArtifact.mock.calls).toEqual([['auth.json', `{"key":"value"}`]]);
});

test('writeAuth empty auth', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/build/writeConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { serializer } from '@lowdefy/helpers';
async function writeConfig({ components, context }) {
await context.writeBuildArtifact(
'config.json',
serializer.serializeToString(components.config ?? {}, { space: 2 })
serializer.serializeToString(components.config ?? {})
);
}

Expand Down
9 changes: 1 addition & 8 deletions packages/build/src/build/writeConfig.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ test('writeConfig', async () => {
},
};
await writeConfig({ components, context });
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'config.json',
`{
"key": "value"
}`,
],
]);
expect(mockWriteBuildArtifact.mock.calls).toEqual([['config.json', `{"key":"value"}`]]);
});

test('writeConfig empty config', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/build/writeConnections.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async function writeConnections({ components, context }) {
const writePromises = components.connections.map(async (connection) => {
await context.writeBuildArtifact(
`connections/${connection.connectionId}.json`,
serializer.serializeToString(connection, { space: 2 })
serializer.serializeToString(connection)
);
});
return Promise.all(writePromises);
Expand Down
18 changes: 3 additions & 15 deletions packages/build/src/build/writeConnections.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,7 @@ test('writeConnections write connection', async () => {
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'connections/connection1.json',
`{
"id": "connection:connection1",
"connectionId": "connection1",
"properties": {
"prop": "val"
}
}`,
`{"id":"connection:connection1","connectionId":"connection1","properties":{"prop":"val"}}`,
],
]);
});
Expand All @@ -71,17 +65,11 @@ test('writeConnections multiple connection', async () => {
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'connections/connection1.json',
`{
"id": "connection:connection1",
"connectionId": "connection1"
}`,
`{"id":"connection:connection1","connectionId":"connection1"}`,
],
[
'connections/connection2.json',
`{
"id": "connection:connection2",
"connectionId": "connection2"
}`,
`{"id":"connection:connection2","connectionId":"connection2"}`,
],
]);
});
Expand Down
5 changes: 1 addition & 4 deletions packages/build/src/build/writeGlobal.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ async function writeGlobal({ components, context }) {
if (!type.isObject(components.global)) {
throw new Error('Global is not an object.');
}
await context.writeBuildArtifact(
'global.json',
serializer.serializeToString(components.global, { space: 2 })
);
await context.writeBuildArtifact('global.json', serializer.serializeToString(components.global));
}

export default writeGlobal;
9 changes: 1 addition & 8 deletions packages/build/src/build/writeGlobal.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ test('writeGlobal', async () => {
},
};
await writeGlobal({ components, context });
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'global.json',
`{
"key": "value"
}`,
],
]);
expect(mockWriteBuildArtifact.mock.calls).toEqual([['global.json', `{"key":"value"}`]]);
});

test('writeGlobal empty global', async () => {
Expand Down
10 changes: 2 additions & 8 deletions packages/build/src/build/writeMaps.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,8 @@ async function writeMaps({ context }) {
if (!type.isObject(context.refMap)) {
throw new Error('refMap is not an object.');
}
await context.writeBuildArtifact(
'keyMap.json',
serializer.serializeToString(context.keyMap, { space: 0 })
);
await context.writeBuildArtifact(
'refMap.json',
serializer.serializeToString(context.refMap, { space: 0 })
);
await context.writeBuildArtifact('keyMap.json', serializer.serializeToString(context.keyMap));
await context.writeBuildArtifact('refMap.json', serializer.serializeToString(context.refMap));
}

export default writeMaps;
5 changes: 1 addition & 4 deletions packages/build/src/build/writeMenus.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ async function writeMenus({ components, context }) {
if (!type.isArray(components.menus)) {
throw new Error('Menus is not an array.');
}
await context.writeBuildArtifact(
'menus.json',
serializer.serializeToString(components.menus, { space: 2 })
);
await context.writeBuildArtifact('menus.json', serializer.serializeToString(components.menus));
}

export default writeMenus;
11 changes: 1 addition & 10 deletions packages/build/src/build/writeMenus.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,7 @@ test('writeMenus', async () => {
};
await writeMenus({ components, context });
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'menus.json',
`[
{
"id": "menu:default",
"menuId": "default",
"links": []
}
]`,
],
['menus.json', `[{"id":"menu:default","menuId":"default","links":[]}]`],
]);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/build/writePages.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { serializer } from '@lowdefy/helpers';
async function writePage({ page, context }) {
await context.writeBuildArtifact(
`pages/${page.pageId}/${page.pageId}.json`,
serializer.serializeToString(page ?? {}, { space: 2 })
serializer.serializeToString(page ?? {})
);
}

Expand Down
21 changes: 3 additions & 18 deletions packages/build/src/build/writePages.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@ test('writePages write page', async () => {
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'pages/page1/page1.json',
`{
"id": "page:page1",
"pageId": "page1",
"blockId": "page1",
"requests": []
}`,
`{"id":"page:page1","pageId":"page1","blockId":"page1","requests":[]}`,
],
]);
});
Expand All @@ -73,21 +68,11 @@ test('writePages multiple pages', async () => {
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'pages/page1/page1.json',
`{
"id": "page:page1",
"pageId": "page1",
"blockId": "page1",
"requests": []
}`,
`{"id":"page:page1","pageId":"page1","blockId":"page1","requests":[]}`,
],
[
'pages/page2/page2.json',
`{
"id": "page:page2",
"pageId": "page2",
"blockId": "page2",
"requests": []
}`,
`{"id":"page:page2","pageId":"page2","blockId":"page2","requests":[]}`,
],
]);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/build/writeRequests.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async function writeRequestsOnPage({ page, context }) {
page.requests.map(async (request) => {
await context.writeBuildArtifact(
`pages/${page.pageId}/requests/${request.requestId}.json`,
serializer.serializeToString(request ?? {}, { space: 2 })
serializer.serializeToString(request ?? {})
);
delete request.properties;
delete request.type;
Expand Down
75 changes: 5 additions & 70 deletions packages/build/src/build/writeRequests.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,7 @@ test('writeRequests write request', async () => {
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'pages/page1/requests/request1.json',
`{
"id": "request:page1:request1",
"requestId": "request1",
"pageId": "page1",
"connectionId": "connection1",
"auth": {
"public": true
},
"type": "Request",
"payload": {},
"properties": {
"key": "value"
}
}`,
`{"id":"request:page1:request1","requestId":"request1","pageId":"page1","connectionId":"connection1","auth":{"public":true},"type":"Request","payload":{},"properties":{"key":"value"}}`,
],
]);
});
Expand Down Expand Up @@ -105,37 +92,11 @@ test('writeRequests write multiple requests on a page', async () => {
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'pages/page1/requests/request1.json',
`{
"id": "request:page1:request1",
"requestId": "request1",
"pageId": "page1",
"connectionId": "connection1",
"auth": {
"public": true
},
"type": "Request",
"payload": {},
"properties": {
"key": "value"
}
}`,
`{"id":"request:page1:request1","requestId":"request1","pageId":"page1","connectionId":"connection1","auth":{"public":true},"type":"Request","payload":{},"properties":{"key":"value"}}`,
],
[
'pages/page1/requests/request2.json',
`{
"id": "request:page1:request2",
"requestId": "request2",
"pageId": "page1",
"connectionId": "connection1",
"auth": {
"public": true
},
"type": "Request",
"payload": {},
"properties": {
"key": "value"
}
}`,
`{"id":"request:page1:request2","requestId":"request2","pageId":"page1","connectionId":"connection1","auth":{"public":true},"type":"Request","payload":{},"properties":{"key":"value"}}`,
],
]);
});
Expand Down Expand Up @@ -181,37 +142,11 @@ test('writeRequests write requests on a for multiple pages', async () => {
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'pages/page1/requests/request1.json',
`{
"id": "request:page1:request1",
"requestId": "request1",
"pageId": "page1",
"connectionId": "connection1",
"auth": {
"public": true
},
"type": "Request",
"payload": {},
"properties": {
"key": "value"
}
}`,
`{"id":"request:page1:request1","requestId":"request1","pageId":"page1","connectionId":"connection1","auth":{"public":true},"type":"Request","payload":{},"properties":{"key":"value"}}`,
],
[
'pages/page2/requests/request1.json',
`{
"id": "request:page2:request1",
"requestId": "request1",
"pageId": "page2",
"connectionId": "connection1",
"auth": {
"public": true
},
"type": "Request",
"payload": {},
"properties": {
"key": "value"
}
}`,
`{"id":"request:page2:request1","requestId":"request1","pageId":"page2","connectionId":"connection1","auth":{"public":true},"type":"Request","payload":{},"properties":{"key":"value"}}`,
],
]);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/build/src/build/writeTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { serializer } from '@lowdefy/helpers';
async function writeTypes({ components, context }) {
await context.writeBuildArtifact(
'types.json',
serializer.serializeToString(components.types ?? {}, { space: 2 })
serializer.serializeToString(components.types ?? {})
);
}

Expand Down
9 changes: 1 addition & 8 deletions packages/build/src/build/writeTypes.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,5 @@ test('writeTypes', async () => {
type: 'value',
};
await writeTypes({ components, context });
expect(mockWriteBuildArtifact.mock.calls).toEqual([
[
'types.json',
`{
"type": "value"
}`,
],
]);
expect(mockWriteBuildArtifact.mock.calls).toEqual([['types.json', `{"type":"value"}`]]);
});

0 comments on commit 2e14c4f

Please sign in to comment.