fix(server-dev): Add max count in waitForRestartedServer ping.

lowdefy · Jun 24, 2022 · d7d8a0b · d7d8a0b
1 parent 4c47ba6
commit d7d8a0b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/server-dev/lib/utils/waitForRestartedServer.js b/packages/server-dev/lib/utils/waitForRestartedServer.js
@@ -16,15 +16,21 @@
 
 import request from './request.js';
 
+const MAX_COUNT = 1200; // 10 mins
+
 function waitForRestartedServer(basePath) {
+  let count = 0;
   setTimeout(async () => {
     try {
       await request({
         url: `${basePath}/api/ping`,
       });
       window.location.reload();
     } catch (error) {
-      waitForRestartedServer(basePath);
+      count += 1;
+      if (count <= MAX_COUNT) {
+        waitForRestartedServer(basePath);
+      }
     }
   }, 500); // TODO: this ping should be shorter than rerender delay until we can pass a rebuild flag to reload.
 }

diff --git a/packages/server-dev/manager/run.mjs b/packages/server-dev/manager/run.mjs
@@ -81,6 +81,7 @@ async function run() {
     const serverPromise = startServer(context);
     await wait(800);
     if (process.env.LOWDEFY_SERVER_DEV_OPEN_BROWSER === 'true') {
+      // TODO: Wait 1 sec for a ping and don't open if a ping is seen
       opener(`http://localhost:${context.options.port}`);
     }
     await serverPromise;