Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label validation style render bug. #1350

Merged
merged 19 commits into from Aug 25, 2022
Merged

Fix label validation style render bug. #1350

merged 19 commits into from Aug 25, 2022

Conversation

StephanieJKS
Copy link
Contributor

@StephanieJKS StephanieJKS commented Aug 24, 2022

Closes #ISSUE_NUMBER

What are the changes and their implications?

This PR fixes the bug in which the validate styles were not being applied correctly. These included border color not changing; color of feedback in extra not changing; and the icon not being displayed in the correct position, as well as not changing color.
The fix for the component border color involved setting the status property of the relative components.
The fix for the feedback in the extra involved changing how the classes were applied.
The fix for the icon involved changing the classes applied to the icon.

Checklist

  • Pull request is made to the "develop" branch
  • Tests added
  • Documentation added/updated
  • Code has been formatted with Prettier
  • Edits from maintainers are allowed

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #1350 (1e29169) into develop (424d3bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1350   +/-   ##
========================================
  Coverage    84.08%   84.08%           
========================================
  Files          381      381           
  Lines         4298     4298           
  Branches       930      930           
========================================
  Hits          3614     3614           
  Misses         581      581           
  Partials       103      103           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 8 alerts when merging f7f78e9 into 770d788 - view on LGTM.com

new alerts:

  • 8 for Identical operands

Gervwyk
Gervwyk previously approved these changes Aug 24, 2022
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 8 alerts when merging 65df59d into 770d788 - view on LGTM.com

new alerts:

  • 8 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 9 alerts when merging cd049c6 into 770d788 - view on LGTM.com

new alerts:

  • 9 for Identical operands

Gervwyk
Gervwyk previously approved these changes Aug 24, 2022
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2022

This pull request introduces 9 alerts when merging 280f05d into 424d3bf - view on LGTM.com

new alerts:

  • 9 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Aug 25, 2022

This pull request introduces 1 alert when merging 91a1e8b into 424d3bf - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Aug 25, 2022

This pull request introduces 1 alert when merging 997fae8 into 424d3bf - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Aug 25, 2022

This pull request introduces 1 alert when merging 1e29169 into 424d3bf - view on LGTM.com

new alerts:

  • 1 for Identical operands

@Gervwyk Gervwyk merged commit 4abda25 into develop Aug 25, 2022
@Gervwyk Gervwyk deleted the label-validation branch August 25, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants