Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V4 requests #926

Merged
merged 12 commits into from Nov 3, 2021
Merged

Add V4 requests #926

merged 12 commits into from Nov 3, 2021

Conversation

SamTolmay
Copy link
Member

Closes #ISSUE_NUMBER

What are the changes and their implications?

This PR starts to add requests to the @lowdefy/api and @lowdefy/client packages.

Checklist

  • Pull request is made to the "develop" branch
  • Tests added
  • Documentation added/updated
  • Code has been formatted with Prettier
  • Edits from maintainers are allowed

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #926 (80c00f4) into v4 (efb7f04) will decrease coverage by 3.56%.
The diff coverage is 31.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4     #926      +/-   ##
==========================================
- Coverage   86.57%   83.00%   -3.57%     
==========================================
  Files         418      369      -49     
  Lines        4907     4318     -589     
  Branches     1075      975     -100     
==========================================
- Hits         4248     3584     -664     
- Misses        601      666      +65     
- Partials       58       68      +10     
Impacted Files Coverage Δ
packages/api/src/context/readConfigFile.js 0.00% <0.00%> (ø)
...ackages/api/src/routes/request/authorizeRequest.js 0.00% <0.00%> (ø)
...ages/api/src/routes/request/callRequestResolver.js 0.00% <0.00%> (ø)
...ages/api/src/routes/request/checkConnectionRead.js 0.00% <0.00%> (ø)
...ges/api/src/routes/request/checkConnectionWrite.js 0.00% <0.00%> (ø)
...ckages/api/src/routes/request/evaluateOperators.js 0.00% <0.00%> (ø)
...ages/api/src/routes/request/getConnectionConfig.js 0.00% <0.00%> (ø)
...ges/api/src/routes/request/getConnectionHandler.js 0.00% <0.00%> (ø)
...ackages/api/src/routes/request/getRequestConfig.js 0.00% <0.00%> (ø)
...ckages/api/src/routes/request/getRequestHandler.js 0.00% <0.00%> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb7f04...80c00f4. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2021

This pull request introduces 2 alerts when merging 320c4a1 into 1678373 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2021

This pull request introduces 3 alerts when merging 8aa2642 into 1678373 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

# Conflicts:
#	.pnp.cjs
#	packages/server/package.json
@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2021

This pull request introduces 3 alerts when merging c5c5d07 into efb7f04 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

Gervwyk
Gervwyk previously approved these changes Oct 27, 2021
@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2021

This pull request introduces 3 alerts when merging f6f667d into efb7f04 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2021

This pull request introduces 2 alerts when merging dea25de into efb7f04 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2021

This pull request introduces 3 alerts and fixes 1 when merging 83b885b into efb7f04 - view on LGTM.com

new alerts:

  • 2 for Property access on null or undefined
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request fixes 1 alert when merging 86533ee into efb7f04 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request fixes 1 alert when merging 80c00f4 into efb7f04 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@Gervwyk Gervwyk merged commit 149dba2 into v4 Nov 3, 2021
@Gervwyk Gervwyk deleted the requests branch November 3, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants