Skip to content

Commit

Permalink
Fix for issue with layout height on some Sony devices with Android GB
Browse files Browse the repository at this point in the history
On some Sony Xperia devices with Gingerbread (2.3.x) there're some trashy (?) values in attributes, which HoloEverywhere interprets as "measureWithLargestChild" flag set to true. Therefore layouts where wrongly measured.

// I'm just not sure my changes in yml, as it is completely new for me //
  • Loading branch information
Łukasz Gawin committed Apr 1, 2014
1 parent b41deb2 commit 5482aaa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion library/res/values/rb_styles.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<resources xmlns:tools="http://schemas.android.com/tools">
<style name="Holo" parent="" />
<style name="Holo.AlertDialog" parent="Holo">
<item name="bottomBright">@drawable/dialog_bottom_holo_dark</item>
Expand Down Expand Up @@ -142,6 +142,7 @@
<item name="textAppearanceListItemSmall">?android:textAppearanceMedium</item>
<item name="textColorAlertDialogListItem">@color/primary_text_holo_dark</item>
<item name="toastFrameBackground">@drawable/toast_frame</item>
<item name="android:measureWithLargestChild" tools:ignore="NewApi">false</item>
</style>
<style name="Holo.Base.Theme.Dialog" parent="Holo.Theme">
<item name="android:colorBackgroundCacheHint">@null</item>
Expand Down Expand Up @@ -277,6 +278,7 @@
<item name="textAppearanceListItemSmall">?android:textAppearanceMedium</item>
<item name="textColorAlertDialogListItem">@color/primary_text_holo_light</item>
<item name="toastFrameBackground">@drawable/toast_frame</item>
<item name="android:measureWithLargestChild" tools:ignore="NewApi">false</item>
</style>
<style name="Holo.Base.Theme.Light.DarkActionBar" parent="Theme.AppCompat.Light.DarkActionBar">
<item name="activatedBackgroundIndicator">@drawable/activated_background_holo</item>
Expand Down Expand Up @@ -352,6 +354,7 @@
<item name="textAppearanceListItemSmall">?android:textAppearanceMedium</item>
<item name="textColorAlertDialogListItem">@color/primary_text_holo_light</item>
<item name="toastFrameBackground">@drawable/toast_frame</item>
<item name="android:measureWithLargestChild" tools:ignore="NewApi">false</item>
</style>
<style name="Holo.Button" parent="Holo">
<item name="android:background">@drawable/btn_default_holo_dark</item>
Expand Down
1 change: 1 addition & 0 deletions library/resbuilder/themes$styles/base.yml
Expand Up @@ -20,6 +20,7 @@ blocks:
textAppearanceListItem: ?android:textAppearanceLarge
textAppearanceListItemSmall: ?android:textAppearanceMedium
toastFrameBackground: :drawable/toast_frame
android:measureWithLargestChild: false
BaseDark < Base TextDark:
alertDialogTheme: :style/Holo.Theme.Dialog.Alert
android:windowBackground: :drawable/background_holo_dark
Expand Down

0 comments on commit 5482aaa

Please sign in to comment.