Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightscout Plugin #108

Merged
merged 13 commits into from Feb 6, 2021
Merged

Nightscout Plugin #108

merged 13 commits into from Feb 6, 2021

Conversation

legoandmars
Copy link
Contributor

This plugin allows the user to display blood glucose data through Nightscout.

Preview:
Nightscout Metrics

@legoandmars
Copy link
Contributor Author

legoandmars commented Feb 5, 2021

Unsure what exactly to use for plugin tests since @latest won't have the plugin, so i've just set them to use lowlighter/metrics@master for now

The example is also using an svg from my my own github repo since maintainers don't have a nightscout setup

@lowlighter
Copy link
Owner

Tests from tests.yml are actually mocked so it doesn't really matter 🙂

It looks good to me 👍 I'll merge it tomorrow morning.

(No need to take it into account the linter since you started coding before it was setup, it won't be blocking for merging)

@lowlighter lowlighter merged commit 1656f3c into lowlighter:master Feb 6, 2021
@lowlighter
Copy link
Owner

Thanks for contributing!

@lowlighter lowlighter mentioned this pull request Feb 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants