-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins/pagespeed): improved performance and PWA support, fix(plugins/posts): "dev.to" lowercase username, fix(plugins/base): repositories count, fix(plugins/followup): issues and pull requests count from archived #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for these awesome contributions !
Not a lot to nitpick on this pr, but some changes may be more suited as options
Hello @lowlighter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some changes to make to pass the builds and overall looks good 👍
Also, if you want to add new features/patchs, it's better to make separate pull requests, it makes merging and reviewing easier 😅
Ok I will make sure of that next time🙂 |
Thanks a lot for your contribution @JayantGoel001 ! |
Hello @lowlighter,
Improved the PageSpeedInsight Performance by reducing the number of API calls.
Initially, 4 API calls were made for each category
https://www.googleapis.com/pagespeedonline/v5/runPagespeed?category=${category}&url=https://www.google.com&key=XXXXXX
Updated, Only 1 call is made for all categories
https://www.googleapis.com/pagespeedonline/v5/runPagespeed?url=https://www.google.com&category=performance&category=accessibility&category=best-practices&category=seo&key=XXXXXX
"dev.to" username is always in lowercase.
(fix) : Repositories count in 'Base Content'
Initially --- >
Updated --->
followup plugin issues and pull requests count
Initially --->
but in my issue tab
in my pull request tab
updated --->
The change I made was to add
archived: false
in every query of the user