Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/pagespeed): improved performance and PWA support, fix(plugins/posts): "dev.to" lowercase username, fix(plugins/base): repositories count, fix(plugins/followup): issues and pull requests count from archived #1101

Merged
merged 20 commits into from
Jun 24, 2022

Conversation

JayantGoel001
Copy link
Contributor

@JayantGoel001 JayantGoel001 commented Jun 16, 2022

Hello @lowlighter,

image

Improved the PageSpeedInsight Performance by reducing the number of API calls.

Initially, 4 API calls were made for each category
https://www.googleapis.com/pagespeedonline/v5/runPagespeed?category=${category}&url=https://www.google.com&key=XXXXXX

Updated, Only 1 call is made for all categories
https://www.googleapis.com/pagespeedonline/v5/runPagespeed?url=https://www.google.com&category=performance&category=accessibility&category=best-practices&category=seo&key=XXXXXX

"dev.to" username is always in lowercase.

(fix) : Repositories count in 'Base Content'

Initially --- >

Updated --->
image

followup plugin issues and pull requests count

Initially --->
image

but in my issue tab

image

in my pull request tab

  • merged
    image
  • unmerged(closed)
    image

updated --->

image

The change I made was to add archived: false in every query of the user

@JayantGoel001 JayantGoel001 changed the title Improved PageSpeedInsight Performance Improved PageSpeedInsight Performance & (fix) : "dev.to" username is always in lowercase. Jun 16, 2022
@JayantGoel001 JayantGoel001 changed the title Improved PageSpeedInsight Performance & (fix) : "dev.to" username is always in lowercase. (fix) : Improved PageSpeedInsight Performance, "dev.to" username is always in lowercase & Repositories count in 'Base Content' Jun 17, 2022
@JayantGoel001 JayantGoel001 changed the title (fix) : Improved PageSpeedInsight Performance, "dev.to" username is always in lowercase & Repositories count in 'Base Content' (fix) : Improved PageSpeedInsight Performance, "dev.to" username is always in lowercase, Repositories count in 'Base Content' & follow-up plugin issues and pull requests count Jun 17, 2022
Copy link
Owner

@lowlighter lowlighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these awesome contributions !

Not a lot to nitpick on this pr, but some changes may be more suited as options

source/plugins/base/queries/user.x.graphql Outdated Show resolved Hide resolved
source/plugins/followup/queries/user.graphql Outdated Show resolved Hide resolved
@JayantGoel001
Copy link
Contributor Author

JayantGoel001 commented Jun 22, 2022

Hello @lowlighter,
Added (feat) : PWA Support has been added to PageSpeed

PWA Not Installed
not

PWA Installed
Untitled

Copy link
Owner

@lowlighter lowlighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some changes to make to pass the builds and overall looks good 👍

Also, if you want to add new features/patchs, it's better to make separate pull requests, it makes merging and reviewing easier 😅

source/plugins/base/queries/field.repositories.graphql Outdated Show resolved Hide resolved
source/plugins/pagespeed/examples.yml Show resolved Hide resolved
@JayantGoel001
Copy link
Contributor Author

Still some changes to make to pass the builds and overall looks good 👍

Also, if you want to add new features/patchs, it's better to make separate pull requests, it makes merging and reviewing easier 😅

Ok I will make sure of that next time🙂

@lowlighter lowlighter merged commit f544663 into lowlighter:master Jun 24, 2022
@lowlighter
Copy link
Owner

Thanks a lot for your contribution @JayantGoel001 !

@lowlighter lowlighter changed the title (fix) : Improved PageSpeedInsight Performance, "dev.to" username is always in lowercase, Repositories count in 'Base Content' & follow-up plugin issues and pull requests count feat(plugins/pagespeed): improved performance and PWA support, fix(plugins/posts): "dev.to" lowercase username, fix(plugins/base): repositories count, fix(plugins/followup): issues and pull requests count from archived Jun 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants