Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/sponsors): title option #1128

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

Lissy93
Copy link
Contributor

@Lissy93 Lissy93 commented Jul 7, 2022

Description

This PR makes the title text in the sponsors plugin user-customizable, using the plugin_sponsors_title attribute


Associated Tickets

#1126


Screenshot

Default Custom Title
After After

My first PR here, so let me know if I've missed anything, or if there's anything you'd like me to change. :)

Not sure if it's just that my PC is a potato, but I wasn't able to run the unit tests, they just hung. But I did manually test it, and it seems to work fine in the web app.

@Lissy93
Copy link
Contributor Author

Lissy93 commented Jul 7, 2022

The failing Code Scanning check wasn't from anything I added, but the offending console.log (here) could probably be deleted

const middleware = (req, res, next) => {
console.log(`metrics/app/control > ${req.method} > ${req.url}`)
if (req.headers.authorization === conf.settings.control.token) {
next()
return
}

@lowlighter
Copy link
Owner

Thanks a lot for your contribution !

I'll keep this for v3.27, since v3.26 (#1127) will be more oriented towards web instances (and should be ready in next few days) 👍

@lowlighter lowlighter merged commit e75e00e into lowlighter:master Jul 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants