Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin/achievements): use graphql first for initial setup and fix regex #1532

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

lowlighter
Copy link
Owner

Will first attempts to load total count using github search through GraphQL API for more reliability

If not working, fallback on browser method
Also fixes the current regex to extract results:

- /(?<type>Repositories|Users|Issues)\n(?<count>.*?)M/g 
  // matches [ ", 58", ", 109", ", 119" ]

+ /(?<type>Repositories|Users|Issues)\n.*?(?<count>\d+)M/g
  // matches [ "58", "109", "119" ]

@lowlighter lowlighter merged commit 2e12f12 into master Sep 12, 2023
12 checks passed
@lowlighter lowlighter deleted the fix-plugin-achievements-again branch September 12, 2023 02:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant