Update star icons in classic template

[Milo123459]

• filled star system
• activity: filled star system

Now, when you star a repository, it'll use a filled star icon rather then a blank one (to make it look more like the original GitHub)

[Milo123459]

This also removes libxmljs, I couldn't see it doing anything major and I've started looking into a better soloution rather then using libxmljs.

[lowlighter]

verify feature should not be removed as it is used for units test.

Pupeeteer postinstall and template edits looks nice 👍🏼

[Milo123459]

So this isn't going to be merged until we find an alternative for libxmljs?

[Milo123459]

Preview:

[lowlighter]

So this isn't going to be merged until we find an alternative for libxmljs?

Unless you rebase this to only keep templates changes (though dev and postinstall scripts are fine, though it would be better in another pr too)

It's better to make separate pull requests when scopes are differents, it's less confusing and help to keep track of changes.
Ideally, a pull request content should only have a single subject (e.g. a new feature, same-kind fixes, etc).
It's weird that a pr suggesting patching templates impacts dependencies, core code along with repo-releated files 😅

---

A few additional notes which prevents this to be merged:

• modern-normalize should be removed since it doesn't work here
• verify option code should be restored (required by tests), along with libxml (or libxml moved to optionalDependencies)
• linter:fix seems useless, you can already pass arguments to npm scripts using --, like npm run linter -- --fix
• some svg icons are badly indented (it's minor, but since ejs files are already hard to read, it would be nice to keep indent consistency)

Hope it doesn't discourage you 🙂

[Milo123459]

So this isn't going to be merged until we find an alternative for libxmljs?

Unless you rebase this to only keep templates changes (though dev and postinstall scripts are fine, though it would be better in another pr too)

It's better to make separate pull requests when scopes are differents, it's less confusing and help to keep track of changes.
Ideally, a pull request content should only have a single subject (e.g. a new feature, same-kind fixes, etc).
It's weird that a pr suggesting patching templates impacts dependencies, core code along with repo-releated files 😅

A few additional notes which prevents this to be merged:

• modern-normalize should be removed since it doesn't work here
• verify option code should be restored (required by tests), along with libxml (or libxml moved to optionalDependencies)
• linter:fix seems useless, you can already pass arguments to npm scripts using --, like npm run linter -- --fix
• some svg icons are badly indented (it's minor, but since ejs files are already hard to read, it would be nice to keep indent consistency)

Hope it doesn't discourage you 🙂

Verify is back, linter:fix is indeed useless, some svg are badly indented, modern-normalize will be removed and other things should be fixed soon.

[Milo123459]

I still can't install libxmljs. I have python2.7 installed, ran it with elevated permissions, and nothing. Still doesn't work. I fixed everything else so I will commit that but then this just isn't working!

[Milo123459]

There is our smoking gun

[Milo123459]

I just forcefully wrote it into the package.json.

[lowlighter]

I'm not sure what to think about the change of stars/sponsors icons actually.

It's kind of fine on dark mode but it really look odd on light mode.
I think that's because all of others icons are just strokes and using filled icons looks out of place:

[Milo123459]

Hmm..