Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GitHub URLs in comments #262

Merged
merged 4 commits into from Apr 25, 2021
Merged

Simplify GitHub URLs in comments #262

merged 4 commits into from Apr 25, 2021

Conversation

Nixinova
Copy link
Contributor

@Nixinova Nixinova commented Apr 24, 2021

Resolve #254

Turns links such as https://github.com/lowlighter/metrics/issues/254 into lowlighter/metrics#254 or #254 depending on the repository.
Applies to both issues/PRs and commits.

Copy link
Owner

@lowlighter lowlighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot for your contribution 👍

source/app/web/statics/about/index.html Show resolved Hide resolved
@lowlighter lowlighter merged commit e6c50ca into lowlighter:master Apr 25, 2021
JayantGoel001 referenced this pull request in JayantGoel001/metrics Apr 25, 2021
Simplify GitHub URLs in comments (#262)
@lowlighter lowlighter mentioned this pull request Apr 26, 2021
@Nixinova
Copy link
Contributor Author

Should I also simplify hashes like ed65867add3e671769f182ca73d0e7085ce2c6a5 to ed65867?

@lowlighter
Copy link
Owner

It would be nice yes 🙂

@lowlighter lowlighter mentioned this pull request Apr 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto parse reference to issues/pr in metrics insights
2 participants