Skip to content
This repository has been archived by the owner on Apr 11, 2020. It is now read-only.

removing all proficiencies throws TypeError #16

Closed
phivk opened this issue Dec 2, 2017 · 1 comment
Closed

removing all proficiencies throws TypeError #16

phivk opened this issue Dec 2, 2017 · 1 comment

Comments

@phivk
Copy link

phivk commented Dec 2, 2017

When I remove all proficiencies (as suggested in person.yaml), like such

proficiencies:
  # - list item

the build process throws a throws a TypeError, which prevents the resume being built:

{ TypeError: metalsmith-resume/templates/default.pug:32
    30|               +experience(collections.education[i])
    31| 
  > 32|         if person.proficiencies.length > 0
    33|           +section
    34|             +left-column
    35|               +section-title('Proficiencies')

Cannot read property 'length' of null
    at eval (eval at wrap (metalsmith-resume/node_modules/pug-runtime/wrap.js:6:10), <anonymous>:526:25)

I'm on OSX 10.12.6 using latest node (5.5.1)

@phivk
Copy link
Author

phivk commented Dec 2, 2017

I found a simple fix in default.pug and submitted this PR:
#17

lowmess added a commit that referenced this issue Dec 3, 2017
fix #16 'removing all proficiencies throws TypeError'
@lowmess lowmess closed this as completed Dec 3, 2017
@lowmess lowmess reopened this Dec 3, 2017
@lowmess lowmess closed this as completed in af0a0d4 Dec 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants