Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Adding support for different fetch mode #5

Closed
wants to merge 1 commit into from

Conversation

creativej
Copy link

@lox
Copy link
Owner

lox commented Nov 5, 2012

Not overly keen on this, fetch mode should always be associative arrays. Why not just use array_values on the result if you want an ordinal array?

@lox
Copy link
Owner

lox commented Nov 19, 2012

Ping @creativej

@lox lox closed this Nov 26, 2012
@creativej
Copy link
Author

Sorry @lox missed the ping! The problem with associative arrays is that it only holds fields with a unique names. This will cause problem for joins.

I am not sure if array_values can work here, I will double check!

@lox lox reopened this Dec 6, 2012
@lox
Copy link
Owner

lox commented Dec 6, 2012

Yeah, fair point. This requires some thought.

@lox
Copy link
Owner

lox commented Dec 11, 2012

Ping @rbone and @mtibben:

What do you guys think? How should we support results with duplicate columns?

@rbone
Copy link
Collaborator

rbone commented Dec 12, 2012

Still undecided on this one. The intent behind this is to enable joins to return unambiguous values for each domain object relevant to them e.g. if I select a series of posts, and I also want to select all the users to those posts, I want to ensure any common fields that might be present such as timecreated are maintained.

So the question I have is, does Pheasant already have an answer in mind for this use case? If it does then I'd probably shy away from a change like this to try and avoid unnecessary complexity.

@rbone
Copy link
Collaborator

rbone commented Aug 24, 2017

Closing this as I don't believe it is likely to advance any further. If I'm wrong feel free to reopen it again.

@rbone rbone closed this Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants