Ability to disable clock to run Ember Acceptance tests #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lozjackson
reviewed
Jul 29, 2018
app/services/clock.js
Outdated
| import Service from 'ember-clock/services/clock' | ||
| export default Service.extend({ | ||
| disabled: ENV['ember-clock'] && ENV['ember-clock'].disabled |
There was a problem hiding this comment.
@rbezemer When I run the tests I get this error
Only string, number, symbol, boolean, null, undefined, and function are allowed as default properties (ember/avoid-leaking-state-in-ember-objects)
Can you set the disabled flag in a constant like this:
const disabled = ENV['ember-clock'] && ENV['ember-clock'].disabled
export default Service.extend({
disabled
})
lozjackson
requested changes
Jul 29, 2018
There was a problem hiding this comment.
@rbezemer Thanks for submitting this PR. Sorry its taken me a while to get around to reviewing this.
I've left a comment in the code requesting a minor change.
|
Sorry about that, the lint should be gone now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIth new versions of ember it is discouraged to mock services. This changes allows a user to disable the updating of the clock service run loop while running acceptance tests.