Add a last state change filter and handy sorting options #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 7, 2015 15:44
- Some undefined variables, scoping, and incorrect key names.
- Filter by last state change with hard-coded values of the last 15minutes, 1 hour, 12 hours, 1 day, and 1 week. - Expose the config value as a checkbox in the settings dialog. Allow the user to override it and store that value in a cookie. - Allow the output to be sorted in descending order. This works for the default (hostnames) and sorting by time. - Added some CSS for padding things around words and checkboxes in the settings dialog box.
… rather than hard-coding them. - Updated the config example with good starting points for last state change time periods. - Fixed a minor bug around $filter_sort_by_time.
| echo '<label class="checkbox inline tag_label">'; | ||
| echo '<input type="checkbox" name="sort_descending"' . $checked_sort_descending . '>'; | ||
| echo '</label>'; | ||
| echo '</span>'; |
There was a problem hiding this comment.
can we move this block out of the <?php clause and make it plain HTML and only activate php for the variable stuff? Would make it much easier to read or change.
There was a problem hiding this comment.
That's reasonable.
RyanFrantz
added a commit
that referenced
this pull request
Mar 20, 2015
Add a last state change filter and handy sorting options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$sort_by_timeconfig value as a checkbox in the settings dialog. Allow the user to override it and store that value in a cookie.I think I'll still owe you a minor update to the
READMEabout these feature updates, and probably a 5-minute demo.