bugfix

README.md

@@ -167,7 +167,7 @@ Add following snippets to your ``pom.xml`` file to import the library:
         <dependency>    
             <groupId>neuralnetwork</groupId>    
             <artifactId>neural-network-repo</artifactId>    
-            <version>2.3</version>    
+            <version>2.4</version>    
         </dependency>    
     </dependencies>    
 

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>neuralnetwork</groupId>
     <artifactId>neural-network-repo</artifactId>
-    <version>2.3</version>
+    <version>2.4</version>
     <build>
         <plugins>
             <plugin>

src/main/java/neuralnet/NeuralNetwork.java

@@ -33,7 +33,7 @@ public class NeuralNetwork implements Serializable {
     private double initialLearningRate;
     private double learningRate;
     private double momentum;
-    private int iteration_count;
+    private int iterationCount;
 
     static {
         URL path = NeuralNetwork.class.getClassLoader().getResource("neuralnetwork.properties");
@@ -150,7 +150,7 @@ public List<Double> learn(double[] inputNodes, double[] expectedOutputNodes) {
         Matrix target = Matrix.fromArray(rectifier, expectedOutputNodes);
 
         // backward propagate to adjust weights in layers
-        iteration_count++;
+        iterationCount++;
         Matrix error = null;
         for (int i = steps.size()-1; i >= 0; i--) {
             if (error == null) {
@@ -219,7 +219,12 @@ public NeuralNetwork mutate() {
      */
     public NeuralNetwork copy() {
         NeuralNetwork neuralNetwork = new NeuralNetwork(inputLayerNodes, layers);
-        neuralNetwork.setRectifier(this.rectifier).setLearningRateDescent(this.learningRateDescent).setLearningRate(this.learningRate).setMomentum(this.momentum);
+        neuralNetwork.rectifier = this.rectifier;
+        neuralNetwork.learningRateDescent = this.learningRateDescent;
+        neuralNetwork.momentum = this.momentum;
+        neuralNetwork.initialLearningRate = this.initialLearningRate;
+        neuralNetwork.learningRate = this.learningRate;
+        neuralNetwork.iterationCount = this.iterationCount;
         return neuralNetwork;
     }
 
@@ -295,8 +300,8 @@ public double getLearningRate() {
      * Decreases the current learning rate according to the chosen LearningRateDescent function.
      */
     public void decreaseLearningRate() {
-        this.learningRate = learningRateDescent.decrease(initialLearningRate, momentum, iteration_count);
-        iteration_count++;
+        this.learningRate = learningRateDescent.decrease(initialLearningRate, momentum, iterationCount);
+        iterationCount++;
     }
 
     /**
@@ -389,7 +394,7 @@ public String toString() {
 
     @Override
     public int hashCode() {
-        return Integer.parseInt(learningRate + "" + iteration_count + layers.size());
+        return Integer.parseInt(learningRate + "" + iterationCount + layers.size());
     }
 
     @Override

src/test/java/util/LearningRateDecreaseTest.java

@@ -16,7 +16,7 @@ void descentTest(LearningRateDescent lrd) {
         System.out.println("testing with: " + lrd.getDescription());
         int iter = 250;
         for (int i = 0; i < iter; i++) {
-            lr = lrd.decrease(lrinit, 0.005, i);
+            lr = lrd.decrease(lr, 0.005, i);
         }
         System.out.println("learning rate " + lr + " after " + iter + " iterations.\n");
     }