-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump tool version #75
Conversation
I think this forgot to update the tools in Lines 67 to 69 in 29d8428
|
that was intentional, there are 2 types of pacs in this repository:
The new pacs don't use the generate.sh, but rather the same process as is done over @ stm32-rs. as I did not want to create breaking change when introducing this updated workflow, the generate.sh was not updated for that, but if you want to try to update the tools for the legacy pacs, I'd happily merge the PR! The idea at some point is to update the legacy pacs to the new workflow, but they have not been maintained for a long time, so it would break the HALs to do that as well. |
Ah, makes sense. Unfortunately |
then you can try with a more recent one, I'll see if I can do a PR later today |
Thanks, I'll try with 0.24.1. Unrelated to this, I do currently own |
ah nice! well regarding the lpc13xx, I think adding it as a new style PAC would be best, normally, all the steps are in the readme, and I can troubleshoot with you any issues you might have, and for the lpc81x-pac, the worry is that depending on how long ago the hal was published, there might be a lot of breaking changes introduces, as well as any fix to the original SVD. If you want to move the HAL under lpc-rs, that could be done as well, and I think we could add you as a team member? |
For lpc81x I did keep the original vendor SVD file (v0.3) as well as my manually-patched version: https://github.com/lucab/lpc81x-pac/tree/master/svd. |
there is a more recent svd2rust but it seems that svd2rust PR #649 has broken something, so that will be bumped later.