Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tool version #75

Merged
merged 2 commits into from
Sep 30, 2022
Merged

bump tool version #75

merged 2 commits into from
Sep 30, 2022

Conversation

allexoll
Copy link
Contributor

there is a more recent svd2rust but it seems that svd2rust PR #649 has broken something, so that will be bumped later.

Cluster SECCHANNEL[%s] has size 24928 bits that is more then array increment 256 bits

@github-actions
Copy link

Memory map comparison

@allexoll allexoll merged commit 29d8428 into lpc-rs:master Sep 30, 2022
@lucab
Copy link
Contributor

lucab commented Dec 16, 2022

I think this forgot to update the tools in generate.sh:

lpc-pac/generate.sh

Lines 67 to 69 in 29d8428

require_command svd2rust 0.24.0
require_command cargo-fmt
require_command form 0.8.0

@allexoll
Copy link
Contributor Author

that was intentional, there are 2 types of pacs in this repository:

  • legacy: lpc11uxx, lpc82x, lpc845
  • "new" : lpc546xx and lpc81x (unpublished)

The new pacs don't use the generate.sh, but rather the same process as is done over @ stm32-rs.

as I did not want to create breaking change when introducing this updated workflow, the generate.sh was not updated for that, but if you want to try to update the tools for the legacy pacs, I'd happily merge the PR!

The idea at some point is to update the legacy pacs to the new workflow, but they have not been maintained for a long time, so it would break the HALs to do that as well.

@lucab
Copy link
Contributor

lucab commented Dec 16, 2022

Ah, makes sense. Unfortunately svd2rust-0.24.0 has been yanked so it is not directly installable anymore.

@allexoll
Copy link
Contributor Author

then you can try with a more recent one, I'll see if I can do a PR later today

@lucab
Copy link
Contributor

lucab commented Dec 16, 2022

Thanks, I'll try with 0.24.1.
But I was really trying to have newer LPC13xx PACs, I guess I'll try using the new style instead.

Unrelated to this, I do currently own lpc81x-pac on crates.io and I'll be happy so coordinate publishing a new version from lpc-pac sources.

@allexoll
Copy link
Contributor Author

ah nice! well regarding the lpc13xx, I think adding it as a new style PAC would be best, normally, all the steps are in the readme, and I can troubleshoot with you any issues you might have,

and for the lpc81x-pac, the worry is that depending on how long ago the hal was published, there might be a lot of breaking changes introduces, as well as any fix to the original SVD. If you want to move the HAL under lpc-rs, that could be done as well, and I think we could add you as a team member?

@lucab
Copy link
Contributor

lucab commented Dec 16, 2022

For lpc81x I did keep the original vendor SVD file (v0.3) as well as my manually-patched version: https://github.com/lucab/lpc81x-pac/tree/master/svd.
However I don't own the lpc81x-hal crate, for that one you'll have to ask @apparentlymart.

@allexoll allexoll mentioned this pull request Dec 16, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants