Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon image for both ios (not transparent) and android (transparent) #6

Closed
kctang opened this issue Jul 24, 2016 · 3 comments
Closed

Comments

@kctang
Copy link

kctang commented Jul 24, 2016

Having some issues using a single source icon that works smoothly for both iOS and Android.

  1. To ensure that app icons in Android shows up nicely as notification icons, its background should be transparent.
  2. For iOS, transparent icon background is not recommended to avoid black background.

Right now, it seems we can only have one or the other...and need to use separate icons based on platform. Any solution or thoughts on this?

@lpender
Copy link
Owner

lpender commented Aug 9, 2016

Thanks for pointing this out.

For the time being it seems like you'd have to hack around it.

Run it once with a non-transparent background.

Copy the the resources directory.

Then run it with a transparent background.

Copy the files in the resources directory (inside splashes and icons) that start with android the corresponding target directory in your app.

lpender added a commit that referenced this issue Aug 9, 2016
lpender added a commit that referenced this issue Aug 9, 2016
@lpender lpender mentioned this issue Aug 9, 2016
lpender added a commit that referenced this issue Aug 30, 2016
@lpender
Copy link
Owner

lpender commented Aug 30, 2016

@kctang care to have a look at this pull request? #7

Happy to merge it in but a second set of eyes would be helpful.

@kctang
Copy link
Author

kctang commented Sep 1, 2016

@lpender Sure. I just tried out icons generated by #7 on my app - works!

Other comments/observations that should not prevent #7 from being merged.:

  • Would be good if the bundled icon-android.png has transparent background so that when used as notification icon, it does not looks like a "white square".
  • The bundled splash-android.png is too "wide" for Android portrait layout (on my One Plus One).
  • For my use case, I did not use separate splash images for Android & iOS. Is it really needed?

Thanks for this convenient tool.

@lpender lpender closed this as completed Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants