Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Function spacing is inconsistent #12

Closed
cschneid opened this issue Jun 6, 2017 · 5 comments
Closed

Function spacing is inconsistent #12

cschneid opened this issue Jun 6, 2017 · 5 comments

Comments

@cschneid
Copy link

cschneid commented Jun 6, 2017

There is sometimes 2 lines between functions, sometimes none. I don't see a pattern.

See input & output: https://gist.github.com/cschneid/5eb14df36143b6080db5bbb9fee697b5

@cschneid
Copy link
Author

cschneid commented Jun 6, 2017

(this issue is broken out from #10)

@lpil
Copy link
Owner

lpil commented Jun 6, 2017

I believe I may have just fixed this with dada9f0. Could you try from the master branch please? :)

@cschneid
Copy link
Author

cschneid commented Jun 6, 2017

👍
Looks like it is fixed. Currently looks like: 2 spaces between functions, 1 space between clauses of the same function.

@cschneid
Copy link
Author

cschneid commented Jun 6, 2017

Similar issue with "constants" at the top of the file:

raw

  # 60 seconds
  # @tick_interval 60_000
  @tick_interval 10_000

  ## Client API

  def start_link do
    GenServer.start_link(__MODULE__, :ok, [name: __MODULE__])
  end

formatted

  # 60 seconds
  # @tick_interval 60_000
  @tick_interval 10000
  ## Client API
  def start_link do
    GenServer.start_link __MODULE__, :ok, name: __MODULE__
  end

@lpil
Copy link
Owner

lpil commented Jun 6, 2017

Excellent. I had the idea for this fix while at dancing at the Algorave. If also all debugging could be as much fun. :)

Mind opening a new issue for that module attribute spacing issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants