Django 2.0 Fixes. #1
Conversation
| @@ -59,13 +62,17 @@ def get_version(package): | |||
| 'Framework :: Django', | |||
There was a problem hiding this comment.
Drop 1.9 and 1.10 here, and lose Python 3.3.
test_project/urls.py
Outdated
| import django | ||
| from pkg_resources import parse_version | ||
|
|
||
| if parse_version(django.__version__) >= parse_version('2.0.0'): |
There was a problem hiding this comment.
Use a try ... except ImportError not an if, and don't use path() use url() instead.
test_project/urls.py
Outdated
| # Examples: | ||
| # url(r'^$', 'test_project.views.home', name='home'), |
There was a problem hiding this comment.
Leave these url()s as they were, just omit the patterns() in favour of a plain list.
| deps = | ||
| django |
There was a problem hiding this comment.
Don't use github tarballs, install versions from pypi (except for master).
|
I've added commits based on your feedback. |
tox.ini
Outdated
| {py27,py34,py35}-1.10.x | ||
| {py27,py34,py35,py36}-1.11.x | ||
| {py34,py35,py36}-2.0.x | ||
| {py35,py36}-master |
There was a problem hiding this comment.
master will need to have an associated github tarball in deps. Or just don't test against master.
There was a problem hiding this comment.
Sorry, that was accidental.
There was a problem hiding this comment.
I've removed the reference to master now.
|
Can you update the .travis.yml file as well. |
|
Sure. I wasn't sure if you wanted to do that. |
1 similar comment
on_deletevalues for the models and migrations where needed.