Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to httpclient5 #13

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Upgrade to httpclient5 #13

merged 6 commits into from
Jul 19, 2022

Conversation

41zu
Copy link
Contributor

@41zu 41zu commented Jul 5, 2022

Hi again,

I reworked the code and now all tests are passing. I also tested it in my personal Java project and even on Android (here is a screenshot https://www.dropbox.com/s/0twizzfz6xvpymd/2022-07-05_12-57.png?dl=0).

I would be delighted if you could merge the code and maybe release version 1.4 on maven central ;)

Thank you in advance

@lpradel lpradel self-requested a review July 13, 2022 18:25
@lpradel lpradel self-assigned this Jul 13, 2022
@lpradel
Copy link
Owner

lpradel commented Jul 13, 2022

I just got back from vacation, will take a look soon!

@41zu
Copy link
Contributor Author

41zu commented Jul 13, 2022

Ok,
and I just wanted to let you know, the CI check fails because of the following error: "Either repository token or service with job id must be defined"

Copy link
Owner

@lpradel lpradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well tested it as well and works. Could you please rebase master into your feature branch? I tried to fix the annoying issue with GH action failing on pull requests

@41zu
Copy link
Contributor Author

41zu commented Jul 18, 2022

Done. Had also to do a commit to retrigger the CI

@lpradel lpradel merged commit 638b5a9 into lpradel:master Jul 19, 2022
@lpradel
Copy link
Owner

lpradel commented Jul 19, 2022

@41zu Just released 1.4 to Maven central should be available in 1-2 days.

@41zu
Copy link
Contributor Author

41zu commented Jul 19, 2022

@lpradel Ok, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants