-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to httpclient5 #13
Conversation
I just got back from vacation, will take a look soon! |
Ok, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as well tested it as well and works. Could you please rebase master into your feature branch? I tried to fix the annoying issue with GH action failing on pull requests
Done. Had also to do a commit to retrigger the CI |
@41zu Just released 1.4 to Maven central should be available in 1-2 days. |
@lpradel Ok, thank you :) |
Hi again,
I reworked the code and now all tests are passing. I also tested it in my personal Java project and even on Android (here is a screenshot https://www.dropbox.com/s/0twizzfz6xvpymd/2022-07-05_12-57.png?dl=0).
I would be delighted if you could merge the code and maybe release version 1.4 on maven central ;)
Thank you in advance