Dependency updates #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ create new method closeMocks which closes the AutoCloseable returnes by openMocks
|
Good job, I was hoping I would find some time to do it myself 👀 but yeah I saw already that to fix the CVE we would have to bump TestNG and thereby go Java 11 after all. |
|
@lpradel I just noticed, Java 11 is only required to run the tests. We can still compile the classes to Java 8. Changed the pom to Java 8 again. So it would be enough to just release version 1.4.2 because, we only update dependencies. |
|
@lpradel thank you for merging and releasing the new version 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I updated all dependencies again, plus TestNG and Mockito to their respective latest versions (TestNG has a new CVE).
But the new TestNG version needs Java 11, so we have to finally bump it up.
Plus I removed a few unused warnings.
I would appreciate it if you could release a new version. I would argue for 1.5 because we had to upgrade to a new major Java version.
Best regards
41zu