-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dota2 Api #7
Dota2 Api #7
Conversation
renamed request classes to conform to the naming convention fixed bug in GetLiveLeagueGamesRequest
added additional methods enriched factory
Hi @Pazus, thanks a lot! As your changes are quite substantial, please allow me a few days to look through them. |
I'm not sure, dose Travis error caused by my changes? |
Could you please rename the directory
to
I suspect that the capital 'D' may throw off Travis here. Building your branch worked on my machine. |
Sorry for the trully long responce |
1 similar comment
Could you please look at the error in Travis. |
increased coverage
I'm pretty sure the error in Travis is actually a Travis bug. Thank you for your work, feel free to keep contributing! |
Also, let me know when you are done with this feature because I want to build a major release shortly after. |
Could you restart the build to check if its Travis bug? |
It works now: https://travis-ci.org/lpradel/steam-web-api-java/builds/185827894 Are you done with this feature? |
At least I'm not going to add new things to it :) |
Thank you for all your work on this! I will release a new major version with it soon. |
Added Dota 2 API methods based on https://wiki.teamfortress.com/wiki/WebAPI#Dota_2.
This is my first pull request so please guide me a bit.