Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dota2 Api #7

Merged
merged 11 commits into from Apr 16, 2017
Merged

Dota2 Api #7

merged 11 commits into from Apr 16, 2017

Conversation

@Pazus
Copy link
Contributor

Pazus commented Jul 5, 2016

Added Dota 2 API methods based on https://wiki.teamfortress.com/wiki/WebAPI#Dota_2.

This is my first pull request so please guide me a bit.

Pazus added 3 commits Jun 25, 2016
renamed request classes to conform to the naming convention
fixed bug in GetLiveLeagueGamesRequest
added additional methods
enriched factory
@lpradel

This comment has been minimized.

Copy link
Owner

lpradel commented Jul 6, 2016

Hi @Pazus, thanks a lot! As your changes are quite substantial, please allow me a few days to look through them.

@Pazus

This comment has been minimized.

Copy link
Contributor Author

Pazus commented Jul 22, 2016

I'm not sure, dose Travis error caused by my changes?

@lpradel

This comment has been minimized.

Copy link
Owner

lpradel commented Jul 31, 2016

Could you please rename the directory

src/main/resources/com/lukaspradel/steamapi/schema/Dota2/

to

src/main/resources/com/lukaspradel/steamapi/schema/dota2/

I suspect that the capital 'D' may throw off Travis here. Building your branch worked on my machine.

@Pazus

This comment has been minimized.

Copy link
Contributor Author

Pazus commented Nov 19, 2016

Sorry for the trully long responce

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 19, 2016

Coverage Status

Coverage decreased (-7.0001%) to 88.34% when pulling 061d440 on Pazus:dota2-api-requests into 7c8a9c1 on lpradel:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage decreased (-6.8%) to 88.564% when pulling 859ba13 on Pazus:dota2-api-requests into 7c8a9c1 on lpradel:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 17, 2016

Coverage Status

Coverage increased (+0.2%) to 95.501% when pulling 96fc19e on Pazus:dota2-api-requests into 7c8a9c1 on lpradel:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 17, 2016

Coverage Status

Coverage increased (+0.2%) to 95.501% when pulling 96fc19e on Pazus:dota2-api-requests into 7c8a9c1 on lpradel:master.

@Pazus

This comment has been minimized.

Copy link
Contributor Author

Pazus commented Dec 17, 2016

Could you please look at the error in Travis.

increased coverage
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 17, 2016

Coverage Status

Coverage increased (+0.8%) to 96.144% when pulling 6ff6a85 on Pazus:dota2-api-requests into 7c8a9c1 on lpradel:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 17, 2016

Coverage Status

Coverage increased (+0.8%) to 96.104% when pulling 6857a59 on Pazus:dota2-api-requests into 7c8a9c1 on lpradel:master.

@lpradel

This comment has been minimized.

Copy link
Owner

lpradel commented Dec 17, 2016

I'm pretty sure the error in Travis is actually a Travis bug. Thank you for your work, feel free to keep contributing!

@lpradel

This comment has been minimized.

Copy link
Owner

lpradel commented Dec 17, 2016

Also, let me know when you are done with this feature because I want to build a major release shortly after.

@Pazus

This comment has been minimized.

Copy link
Contributor Author

Pazus commented Apr 16, 2017

Could you restart the build to check if its Travis bug?

@lpradel

This comment has been minimized.

Copy link
Owner

lpradel commented Apr 16, 2017

It works now: https://travis-ci.org/lpradel/steam-web-api-java/builds/185827894

Are you done with this feature?

@Pazus

This comment has been minimized.

Copy link
Contributor Author

Pazus commented Apr 16, 2017

At least I'm not going to add new things to it :)

@lpradel

This comment has been minimized.

Copy link
Owner

lpradel commented Apr 16, 2017

Thank you for all your work on this! I will release a new major version with it soon.

@lpradel lpradel merged commit 6299bf2 into lpradel:master Apr 16, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage increased (+0.8%) to 96.104%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.