Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spurious aborts when retrying transactions #279

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix spurious aborts when retrying transactions #279

wants to merge 2 commits into from

Commits on Nov 19, 2021

  1. Fix spurious aborts when retrying transactions 

    Transactions that enter an error state must be aborted manually by
issuing a "ROLLBACK". However, if the transaction error happened during
a "COMMIT" then the rollback happens automatically. Issuing a "ROLLBACK"
at this point causes PostgreSQL to issue a "WARNING: There is no
transaction in progress". This warning can have much worse causes (e.g.
you "COMMIT" but never began a transaction). This change makes the
transaction retrying logic never cause PostgreSQL to issue this warning
making it a more useful warning for detecting real bugs.
    @3noch @ali-abrar
    3noch authored and ali-abrar committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    c7e42fa View commit details
    Browse the repository at this point in the history

  2. Only catch SqlError in retryLoop

    @3noch @ali-abrar
    3noch authored and ali-abrar committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    7d15beb View commit details
    Browse the repository at this point in the history