Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a config file to not sync some user defined applications (thx @nZac) #49

Merged
merged 10 commits into from
May 15, 2013

Conversation

lra
Copy link
Owner

@lra lra commented May 14, 2013

Hey @nZac, can you tell me if it make sense like this ?
If you could test it also it would be great ;)

I'll merge it if you are cool with it

@nZac
Copy link
Contributor

nZac commented May 14, 2013

If you echo out $HOME on your machine what do you get a trailing slash? I don't...

If you do, then I can add some logic to append a slash if necessary.

@lra
Copy link
Owner Author

lra commented May 14, 2013

👍 @nZac

@nZac
Copy link
Contributor

nZac commented May 14, 2013

Seems to work well on my system. If you care enough to avoid the try/except block you can do this:

if config.read(os.environ['HOME'] + '/.mackup.cfg') == []:
    return []

Up to you...

Otherwise looks good.

@nZac
Copy link
Contributor

nZac commented May 14, 2013

Ohhh and maybe a version bump?

@lra
Copy link
Owner Author

lra commented May 14, 2013

@nZac Yep I'll bump it on master
Forgot to handle the case sensitivity, feel free to propose a better solution if it's not aesthetic enough, I'm not super proud of it ;)

I'll sleep on it anyway.

@nZac
Copy link
Contributor

nZac commented May 14, 2013

See issue #51 for a small update that adds a CLI for ignored files.

As for the case sensitivity, I wonder if making the dict keys for the SUPPORTED_APPS lower case would solve a lot of problems? Then we don't have to worry about calling .lower()

lra added a commit that referenced this pull request May 15, 2013
Added a config file to not sync some user defined applications (thx @nZac)
@lra lra merged commit 386229c into master May 15, 2013
@lra lra deleted the nZac-config-file branch May 15, 2013 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants