xdg support for .mackup.cfg and .mackup #632
Conversation
| @@ -94,7 +94,20 @@ def get_config_files(): | |||
| # Configure the config parser | |||
| apps_dir = os.path.join(os.path.dirname(os.path.realpath(__file__)), | |||
| APPS_DIR) | |||
| custom_apps_dir = os.path.join(os.environ['HOME'], CUSTOM_APPS_DIR) | |||
| xdg_config_home = os.environ.get('XDG_CONFIG_HOME') | |||
| if xdg_config_home: | |||
There was a problem hiding this comment.
it's a lot of copy pasta. Can you add a util that you can use to look for a file in XDG_CONFIG_HOME if set, else in HOME? And use it everywhere?
There was a problem hiding this comment.
Very true. Will do.
|
Would you be ok with 2 utils?
|
|
@lra I updated this with the util functions as requested. I hope this isn't too much to merge at once... |
|
|
||
| # Directory that can contains user defined app configs | ||
| CUSTOM_APPS_DIR = '.mackup' | ||
| if os.environ.get('XDG_CONFIG_HOME'): |
There was a problem hiding this comment.
sorry constants are constants, no code in here.
You can have different constants and pick one or another in functions defined elsewhere (e.g. utils)
There was a problem hiding this comment.
Makes sense. I kinda felt that way too so I put it in a separate commit. Ill fix that.
|
I'll give it another review pass once those comments are dealt with, thanks! |
* upstream/master: changelog Update CHANGELOG.md Update ubersicht.cfg Update CHANGELOG.md Update bettertouchtool.cfg Add support for AppCode 3.2 Update README.md Add configuration for MacDive
|
@lra I made the suggested changes (at least I think I got all of them). Let me know if you want me to rebase/squash... |
|
@lra Just checking up on this... is there something I missed? |
|
no idea, I need to spend time reviewing it. |
|
Any updates here? |
|
@lra Are there any reviews or merge plans for this PR? |
Implements #473