Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iplot(), drop not functioning as described? #164

Closed
roussanoff opened this issue Jun 22, 2021 · 2 comments
Closed

iplot(), drop not functioning as described? #164

roussanoff opened this issue Jun 22, 2021 · 2 comments

Comments

@roussanoff
Copy link

I only recently started using fixest. I use the most recent version 0.9.0. I want to omit a (numerical) factor in the plot of the fixed effects generated by iplot().

library(fixest)
reg1 <- feols(mpg ~ disp + i(carb, ref = 8), data = mtcars)
fdict <-  c("2" = "two", "3" = "three")
etable(reg1, dict = fdict)

The summary replaces values 2 and 3 with the defined labels. However, no category is dropped when I try to run any of the following

iplot(reg1, dict = fdict, drop = "two")
iplot(reg1, dict = fdict, drop = "^two")
iplot(reg1, dict = fdict, drop = "two|three")
iplot(reg1, dict = fdict, drop = "%2")

How do I omit the desired category/ies? Is this actually an issue or did I misread the syntax from the package documentation?

@lrberge
Copy link
Owner

lrberge commented Jun 25, 2021

No, that's currently not working. There are two things.
First, the renaming of levels only (and not the full variable name) is not implemented in coefplot/iplot.
Second, drop/keep does not yet work in iplot.
I'll let you know when it's fixed.

@lrberge
Copy link
Owner

lrberge commented Sep 23, 2021

Hi, drop now should work properly.
The relabeling of vector values is actually very tricky because I have to deduce the intent of the user and it can't always be a win. So I still have to think about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants